Update installing-ocp-agent-inputs.adoc #66032
Conversation
Fixing the issue #66031
openshift-ci
bot
added
the
size/XS
|
🤖 Updated build preview is available at: Build log: https://circleci.com/gh/ocpdocs-previewbot/openshift-docs/27750 |
|
@bmanzari could you please take a look at this PR and let us know what you think? Thanks! |
|
/lgtm |
skopacz1
left a comment
skopacz1
left a comment
There was a problem hiding this comment.
LGTM from a peer review perspective
|
/label peer-review-done |
openshift-ci
bot
added
peer-review-done
|
@Ultimate-etamitlU thanks for your contribution to our docs! |
|
@skopacz1, do we know what versions this applies to? |
|
@jab-rh I'm imagining to all versions where this module exists, so 4.13+, but let me confirm that with an SME/QE. In any case, this PR now needs a rebase, so feel free to remove the merge review label if you'd like me to get everything sorted before requesting another merge review. |
openshift-merge-robot
added
the
needs-rebase
|
Sorry @Ultimate-etamitlU but would you mind rebasing this PR to get rid of the conflicts? I think one of my PRs just merged and caused this issue. (Also, please make sure that you squash any additional commits so that this PR only has one commit at the time of merging) |
|
Just confirmed with QE that this can be applied to 4.13+ |
kalexand-rh
removed
the
merge-review-needed
openshift-merge-robot
removed
the
needs-rebase
|
New changes are detected. LGTM label has been removed. |
openshift-ci
bot
added
size/S
|
|
||
| ifdef::pxe-boot[] | ||
|
|
||
| . Optional: To create an iPXE script, add the `bootArtifactsBaseURL` to the `agent-config.yaml` file: | ||
| + | ||
| [source,yaml] | ||
| ---- | ||
| apiVersion: v1beta1 | ||
| kind: AgentConfig | ||
| metadata: | ||
| name: sno-cluster | ||
| rendezvousIP: 192.168.111.80 | ||
| bootArtifactsBaseURL: <asset_server_URL> | ||
| ---- | ||
| + | ||
| Where `<asset_server_URL>` is the URL of the server you will upload the PXE assets to. | ||
| endif::pxe-boot[] | ||
|
|
||
| ifeval::["{context}" == "prepare-pxe-assets-agent"] | ||
| :!pxe-boot: | ||
| endif::[] No newline at end of file |
There was a problem hiding this comment.
This is content that I merged earlier, which triggered the conflict, but this should be included in the main branch of the docs. Can you add this content back in, and then squash all of your commits into one?
Trying to merge all in one
openshift-ci
bot
added
size/XS
Ultimate-etamitlU
left a comment
Ultimate-etamitlU
left a comment
There was a problem hiding this comment.
Merging all in one
|
Tried by GUI, don't have CLI so will be adding up it tomorrow. Not fond of CLI that much so may be missing something over GUI to collect everything at a place. |
|
Closing this one as there are multiple changes I have on a single file and would be adding a fresh PR to avoid confusion here. |
7 participants
Fixing the issue #66031
Version(s):
Issue:
Link to docs preview:
QE review:
Additional information: